Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for independentSegments #1399

Merged
merged 2 commits into from
May 25, 2023
Merged

Conversation

adrums86
Copy link
Contributor

Description

Adds support for #EXT-X-INDEPENDENT-SEGMENTS tags. This feature depends on this PR in the m3u8 parser.

Specific Changes proposed

Allow VHS to respect independentSegments for m3u8 playlists. This will cause VHS to no longer look backward for the next independent segment if independentSegments is true in the main playlist or the media playlist. If independentSegments is set in the main playlist, it will apply to every segment in every media playlist.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@adrums86 adrums86 self-assigned this May 22, 2023
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #1399 (2b43695) into main (0026717) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1399   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files          40       40           
  Lines       10025    10027    +2     
  Branches     2320     2322    +2     
=======================================
+ Hits         8569     8571    +2     
  Misses       1456     1456           
Impacted Files Coverage Δ
src/segment-loader.js 96.47% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adrums86 adrums86 marked this pull request as ready for review May 22, 2023 16:55
@adrums86 adrums86 merged commit f9a392f into main May 25, 2023
@adrums86 adrums86 deleted the feat-independentSegments branch May 25, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants