Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayBuffer.isView may not be available everywhere - again #1394

Closed
JeppeTh opened this issue Apr 28, 2023 · 1 comment
Closed

ArrayBuffer.isView may not be available everywhere - again #1394

JeppeTh opened this issue Apr 28, 2023 · 1 comment

Comments

@JeppeTh
Copy link

JeppeTh commented Apr 28, 2023

I reported this previously for #1134
Now I get TypeError undefined again for some other live stream. This time inside createTransferableMessage

`

var createTransferableMessage = function createTransferableMessage(message) {
  var transferable = {};
  Object.keys(message).forEach(function (key) {
    var value = message[key];

    if (ArrayBuffer.isView(value)) {
      transferable[key] = {
        bytes: value.buffer,
        byteOffset: value.byteOffset,
        byteLength: value.byteLength
      };
    } else {
      transferable[key] = value;
    }
  });
  return transferable;
};

`

Just add a check if isView is a function doesn't help my play the stream in this case though - possible there are other side effects that needs to be handled.

@JeppeTh
Copy link
Author

JeppeTh commented Apr 28, 2023

Sorry - I was running an old version before the fix was applied. :D
Tried 2.14.2 - don't get that above problem. Even if my stream still doesn't work.
Sorry.

@JeppeTh JeppeTh closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant