feat: add event stream support #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1382 +/- ##
==========================================
+ Coverage 85.37% 85.40% +0.03%
==========================================
Files 40 40
Lines 9954 9963 +9
Branches 2308 2308
==========================================
+ Hits 8498 8509 +11
+ Misses 1456 1454 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wseymour15
reviewed
Mar 21, 2023
wseymour15
approved these changes
Mar 23, 2023
|
@dzianis-dashkevich and @wseymour15 I pushed the refactor, I would appreciate another look at the PR when you have time. Thanks! |
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: This is marked as a draft until the mpd-parser changes are integrated.See
EventStreamPR to mpd-parser: videojs/mpd-parser#170This pull request will take the parsed
EventStreamdata and convert it into a id3-like object which can be added to the metadata text track for use as timed metadata.Specific Changes proposed
Taking the
EventStreamdata from the parsed manifest produced in thehandleMainfunction in the dash-playlist-loader then adding it to the timed metadata text-track via theaddMetadatafunction.Requirements Checklist