chore: npm publish for release workflow #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #1377 +/- ##
=======================================
Coverage 86.37% 86.37%
=======================================
Files 39 39
Lines 9887 9887
Branches 2307 2307
=======================================
Hits 8540 8540
Misses 1347 1347 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
misteroneill
approved these changes
Feb 28, 2023
gkatsev
reviewed
Feb 28, 2023
There was a problem hiding this comment.
can github-release.yml be renamed just release.yml? (The job name and the workflow name will need to be updated in the yml file too.
Also, while we're at it, can you add "discussion_category_name" to the github release action? See https://github.com/videojs/video.js/blob/main/.github/workflows/release.yml#L66 for example
Thanks!
This was referenced Feb 28, 2023
…scussion category name for github releases
|
@gkatsev updated |
gkatsev
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add npm publish step for release workflow
update release documentation
NOTE:
NPM_TOKENshould be added to the repo secrets.