Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: npm publish for release workflow #1376

Merged

Conversation

dzianis-dashkevich
Copy link
Contributor

@dzianis-dashkevich dzianis-dashkevich commented Feb 28, 2023

add npm publish step for release workflow
update release documentation

NOTE: NPM_TOKEN should be added to the repo secrets.

@dzianis-dashkevich dzianis-dashkevich self-assigned this Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #1376 (0ab9759) into main (0890578) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1376   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files          40       40           
  Lines        9957     9957           
  Branches     2313     2313           
=======================================
  Hits         8498     8498           
  Misses       1459     1459           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gkatsev
Copy link
Member

gkatsev commented Feb 28, 2023

Same comments as #1377 (review)

…scussion category name for github releases
@dzianis-dashkevich
Copy link
Contributor Author

@gkatsev updated

@dzianis-dashkevich dzianis-dashkevich merged commit e5b4bf6 into videojs:main Mar 1, 2023
@dzianis-dashkevich dzianis-dashkevich deleted the npm-publish-github-actions branch March 1, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants