-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fmp4 emsg ID3 support #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting as draft until transmuxer changes are integrated, as the tests will fail until we have access to the |
6 tasks
Codecov Report
@@ Coverage Diff @@
## main #1370 +/- ##
==========================================
+ Coverage 85.34% 85.39% +0.04%
==========================================
Files 40 40
Lines 9957 9966 +9
Branches 2313 2314 +1
==========================================
+ Hits 8498 8510 +12
+ Misses 1459 1456 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dzianis-dashkevich
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently VHS does not support passing ID3 frames to the text track from fmp4 segment emsg boxes. With some additional parsing from mux.js and this PR, this enables passing parsed ID3 frame data to the player
textTracks_
for use as timed metadata.Specific Changes proposed
Adding a new function to the
transmuxer-worker
that callsgetEmsgId3
on the transmuxer and returns parsed ID3 frames. Calling the worker function and passing the ID3 frames to theid3Fn
passed in from the mediaSegmentRequest.References:
https://aomediacodec.github.io/id3-emsg/
https://dashif-documents.azurewebsites.net/Events/master/event.html#event-metadata-timing
https://github.com/id3/ID3v2.4/blob/master/id3v2.40-structure.txt
Requirements Checklist