Rename MasterPlaylistController to PlaylistController #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #1309 +/- ##
=======================================
Coverage 86.27% 86.27%
=======================================
Files 39 39
Lines 9791 9791
Branches 2275 2275
=======================================
Hits 8447 8447
Misses 1344 1344
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
We should probably merge the other PRs into |
|
Merge with a BREAKING_CHANGE: footer about the renamed class/properties. |
misteroneill
approved these changes
Aug 17, 2022
BREAKING CHANGE: rename PlaylistController BREAKING CHANGE: rename HAVE_MASTER to HAVE_MAIN_MANIFEST BREAKING CHANGE: playlist loaders updateMain and .main prop rename BREAKING CHANGE: manifest.js exports mainForMedia and addPropertiesToMain BREAKING CHANGE: rename media groups prop to isMainPlaylist BREAKING CHANGE: rename property to mainPlaylistLoader_ BREAKING CHANGE: rename to PlaylistController#main()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.