test: change source for live DASH playback test to fix test failures #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current live DASH playback test source uses a source where segments are referenced by a SegmentTemplate and duration, but the server doesn't have time syncing and appears to be about two minutes behind local time. This leads to requests for segments beyond expected and occasional failures. Until that issue is fixed in VHS, switch to a live source that uses SegmentTemplate, to be a more reliable basic live DASH playback test.
Codecov Report
@@ Coverage Diff @@
## main #1303 +/- ##
=======================================
Coverage 86.31% 86.31%
=======================================
Files 39 39
Lines 9855 9855
Branches 2298 2298
=======================================
Hits 8506 8506
Misses 1349 1349 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gkatsev
approved these changes
Aug 1, 2022
gkatsev
approved these changes
Aug 1, 2022
misteroneill
pushed a commit
that referenced
this pull request
Aug 19, 2022
…1303) The current live DASH playback test source uses a source where segments are referenced by a SegmentTemplate and duration, but the server doesn't have time syncing and appears to be about two minutes behind local time. This leads to requests for segments beyond expected and occasional failures. Until that issue is fixed in VHS, switch to a live source that uses SegmentTemplate, to be a more reliable basic live DASH playback test.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current live DASH playback test source uses a source where segments
are referenced by a SegmentTemplate and duration, but the server
doesn't have time syncing and appears to be about two minutes behind
local time. This leads to requests for segments beyond expected and
occasional failures.
Until that issue is fixed in VHS, switch to a live source that uses
SegmentTemplate, to be a more reliable basic live DASH playback test.
Requirements Checklist