fix: reset transmuxer in resetEverything #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1213 +/- ##
=======================================
Coverage 86.34% 86.34%
=======================================
Files 39 39
Lines 9695 9696 +1
Branches 2244 2244
=======================================
+ Hits 8371 8372 +1
Misses 1324 1324
Continue to review full report at Codecov.
|
brandonocasey
changed the title
gkatsev
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After a call to
resetEverythingwe won't have a videoBuffer. This means that we do not setsegmentInfo.gopsToAlignWith = undefinedas we check for avideoBufferbefore setting it. Which means that we are still using the previousgopsToAlignWithin the transmuxer, which won't be correct. This will cause us to throw out valid video data.