Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: various demo page fixes and enhancements #1186

Merged
merged 11 commits into from
Aug 17, 2021

Conversation

brandonocasey
Copy link
Contributor

@brandonocasey brandonocasey commented Aug 17, 2021

Description

  • Adds back in the run tests link (which is removed on netlify).
  • Correctly disposes of stats on player dispose.
  • Defaults to the new liveui
  • Saves the state of player.muted() to the test page state so that muting/unmuting the player is saved across reloads.
  • Moves the preloaded source dropdown to the top of the form

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #1186 (a59fd0f) into main (8b3533c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1186   +/-   ##
=======================================
  Coverage   86.54%   86.54%           
=======================================
  Files          39       39           
  Lines        9619     9619           
  Branches     2222     2222           
=======================================
  Hits         8325     8325           
  Misses       1294     1294           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3533c...a59fd0f. Read the comment docs.

scripts/index.js Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@@ -122,7 +122,7 @@
</div>

<div class="form-check">
<input id=liveui type="checkbox" class="form-check-input">
<input id=liveui type="checkbox" class="form-check-input" checked>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

index.html Outdated Show resolved Hide resolved
@brandonocasey brandonocasey changed the title chore: add back in run tests link, fix stats interval, default to liveui chore: various demo page fixes and enhancements Aug 17, 2021
@brandonocasey brandonocasey merged commit eef29d4 into main Aug 17, 2021
@brandonocasey brandonocasey deleted the chore/new-demo-fixes branch August 17, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants