-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Caption services (608/708) metadata #1138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
commented
Jun 4, 2021
gkatsev
commented
Jun 4, 2021
Codecov Report
@@ Coverage Diff @@
## main #1138 +/- ##
==========================================
+ Coverage 86.44% 86.45% +0.01%
==========================================
Files 39 39
Lines 9471 9489 +18
Branches 2183 2189 +6
==========================================
+ Hits 8187 8204 +17
- Misses 1284 1285 +1
Continue to review full report at Codecov.
|
gesinger
reviewed
Jun 10, 2021
Co-authored-by: Garrett Singer <[email protected]>
gesinger
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option for caption services metadata in case the user wants to specify labels for 608/708 captions, override the ones provided in the manifest, or needs to add more information like character encoding (this isn't currently available but will be added some time in the future).
For HLS, an
EXT-X-MEDIA
tag can be specified with anINSTREAM-ID
attribute. We already support this. https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis-08#section-4.4.6.1This PR updated mpd-parser which uses the ANSI 214 supplamental spec section 7.2 to parse out the same information from MPD files. videojs/mpd-parser#131.
Adds a property called
captionServices
which has properties of the caption service IDs likeCC1
orSERVICE1
and allows a user to specify alanguage
andlabel
.