feat: support encrypted init segments #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1132 +/- ##
==========================================
+ Coverage 86.20% 86.27% +0.06%
==========================================
Files 39 39
Lines 9289 9325 +36
Branches 2127 2135 +8
==========================================
+ Hits 8008 8045 +37
+ Misses 1281 1280 -1
Continue to review full report at Codecov.
|
brandonocasey
commented
May 24, 2021
| @@ -98,6 +98,15 @@ const handleErrors = (error, request) => { | |||
| }; | |||
| } | |||
|
|
|||
| if (request.responseType === 'arraybuffer' && request.response.byteLength === 0) { | |||
There was a problem hiding this comment.
Added this to handleErrors as it was something that was copy pasted for most of our functions.
brandonocasey
force-pushed
the
feat/encrypted-init-segment
branch
from
b65fe95 to
c4e36bb
Compare
gesinger
reviewed
May 26, 2021
Co-authored-by: Garrett Singer <[email protected]>
Co-authored-by: Garrett Singer <[email protected]>
Co-authored-by: Garrett Singer <[email protected]>
gesinger
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support encrypted init segments