fix: don't clear DASH minimum update period timeout on pause of a media loader #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ia loader Previously, for DASH, pausing a media loader would end up pausing the main loader as well (via removal of the main loader's minimum update period). For live streams which required manifest refreshes, this meant that on media changes, the main loader would be paused and sometimes never resumed. This change ensures that when a media loader is paused it won't remove the main loader's minimum update period timeout. In addition, a change was made so that loading a main DASH playlist loader recreates a minimum update period timeout if the main DASH loader was previously paused (and the timeout cleared).
Codecov Report
@@ Coverage Diff @@
## main #1118 +/- ##
==========================================
+ Coverage 86.29% 86.32% +0.02%
==========================================
Files 38 38
Lines 9068 9072 +4
Branches 2052 2054 +2
==========================================
+ Hits 7825 7831 +6
+ Misses 1243 1241 -2
Continue to review full report at Codecov.
|
brandonocasey
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, for DASH, pausing a media loader would end up pausing the
main loader as well (via removal of the main loader's minimum update
period). For live streams which required manifest refreshes, this meant
that on media changes, the main loader would be paused and sometimes
never resumed.
This change ensures that when a media loader is paused it won't remove
the main loader's minimum update period timeout.
In addition, a change was made so that loading a main DASH playlist
loader recreates a minimum update period timeout if the main DASH loader
was previously paused (and the timeout cleared).
Requirements Checklist