Test/ff 83 #1004
Test/ff 83 #1004
Conversation
| @@ -44,6 +44,11 @@ jobs: | |||
| uses: actions/setup-node@v1 | |||
| with: | |||
| node-version: '${{ steps.nvm.outputs.NVMRC }}' | |||
| # turn off the default setup-node problem watchers... | |||
There was a problem hiding this comment.
Turns off "problem matchers" that add in linter warnings to unchanged files.
| * the time to find the cue at | ||
| * | ||
| * @return {Object|null} | ||
| * the found cue or null | ||
| */ |
There was a problem hiding this comment.
We can remove jsdoc changes, but I already did them, so we might as well keep them.
| @@ -416,7 +416,7 @@ export default class SourceUpdater extends videojs.EventTarget { | |||
| // IE reports that it supports removeSourceBuffer, but often throws | |||
| // errors when attempting to use the function. So we report that it | |||
| // does not support removeSourceBuffer. | |||
| return !videojs.browser.IE_VERSION && window.MediaSource && | |||
| return !videojs.browser.IE_VERSION && !videojs.browser.IS_FIREFOX && window.MediaSource && | |||
There was a problem hiding this comment.
I think this is one of the fixes that we need. It seems like removeSourceBuffer is failing to work correctly in firefox 83.
| @@ -26,6 +17,19 @@ const playFor = function(player, time, cb) { | |||
| }, 10); | |||
| }; | |||
|
|
|||
| if (player.paused()) { | |||
There was a problem hiding this comment.
Actually use the play promise. prevents timeouts for playback tests on firefox.
|
|
||
| this.mediaSource = new window.MediaSource(); | ||
|
|
||
| // need to attach the real media source to a video element for the media source to | ||
| // change to an open ready state | ||
| video.src = URL.createObjectURL(this.mediaSource); | ||
| this.video.src = URL.createObjectURL(this.mediaSource); |
There was a problem hiding this comment.
Not sure if this helped or not, but we should be doing this cleanup.
| assert.ok(true, 'triggered ended event'); | ||
| done(); | ||
| }); | ||
| player.one('ended', () => { |
There was a problem hiding this comment.
All tests still exist here, some were just moved down to be a part of the block that skips tests on firefox.
src/bin-utils.js
Outdated
| @@ -17,6 +18,7 @@ const textRange = function(range, i) { | |||
| * | |||
| * @param {number} e The number | |||
| * @param {number} i the iterator | |||
| * @return {string} the hex formated number as a string | |||
There was a problem hiding this comment.
| * @return {string} the hex formated number as a string | |
| * @return {string} the hex formatted number as a string |
test/playback.test.js
Outdated
| // Catch/silence error when a pause interrupts a play request | ||
| // on browsers which return a promise |
There was a problem hiding this comment.
Might be worth adding in the comment above here (and removing this, since we no longer silence the error)
| }); | ||
| }); | ||
|
|
||
| QUnit[testFn]('Big Buck Bunny Demuxed av, audio only rendition same as group', function(assert) { | ||
| const done = assert.async(); | ||
| if (!videojs.browser.IS_FIREFOX) { |
There was a problem hiding this comment.
Would be worth adding a comment above here
See browserstack results in #1003