Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level codec fixes for Dolby Vision and filtering of unknown codecs #4907

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Sep 14, 2022

This PR will...

Add Dolby Vision four CCs and filter out levels with unknown codecs mixed with levels with known codecs.

Why is this Pull Request needed?

This allows HLS.js to properly filter out levels with Dolby Vision codec strings in browser without support. Where these codecs are supported, SourceBuffers will be created with the correct mime-type strings (#4744).

In the case where HLS.js encounters unknown codecs (as was the case with dvh1 and dva1), since unknown codecs are not filtered using isTypeSupported, they will be removed as long as there are levels that remain that passed the support check.

Resolves issues:

Related to #4744 (This change may resolve that issue if it is an artifact of the SourceBuffer being created with the wrong codec string).

Other considerations:

This is a small change to improve variant filtering and SourceBuffer creation. It does not include robust HDR support with HDR/SDR selection or MediaCapabilities filtering. That will be covered by #2489 and other issues slated for v1.5.

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

…ixed with levels where codecs are known

Related to #4744
Copy link
Collaborator

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. 👌 We may want a followup to avoid mismatches between supported codecs in a given env and our hardcoded list, but that feels out of scope here.

@robwalch robwalch merged commit 9b823ef into master Sep 15, 2022
@robwalch robwalch deleted the feature/dvh1-codec-and-level-filtering branch September 15, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants