Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the 3 times check of TS packet sync byte as optional #5829

Closed
EKW12345 opened this issue Sep 18, 2023 · 2 comments
Closed

Make the 3 times check of TS packet sync byte as optional #5829

EKW12345 opened this issue Sep 18, 2023 · 2 comments

Comments

@EKW12345
Copy link

EKW12345 commented Sep 18, 2023

Is your feature request related to a problem? Please describe.

After version 1.4.0 extra checks were added to verify that the ts packets in the start of the segment, contain sync byte. The commit describes that it was added following to false possitives. We use hls.js to play a hls stream that played well in the old versions of hls.js and since version 1.4.0 it crashes following to exception that says that thousands of ts packets without sync byte were found.

Describe the solution you'd like

Make make this triple check of sync byte optional by configuration.

Additional context

No response

@EKW12345 EKW12345 added Feature proposal Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix. labels Sep 18, 2023
@robwalch
Copy link
Collaborator

Please share an example using the latest release of hls.js.

I would prefer to address this via a bug report than supporting a config option for legacy behavior.

@robwalch robwalch removed the Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix. label Dec 1, 2023
@robwalch
Copy link
Collaborator

robwalch commented Dec 1, 2023

Hi @EKW12345,

We use hls.js to play a hls stream that played well in the old versions of hls.js and since version 1.4.0 it crashes following to exception that says that thousands of ts packets without sync byte were found

I expect this issue to be resolved in v1.5.0 with #5858. You can verify the fix in v1.5.0-alpha.1 or the latest dev build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants