From 86d5267abb96e8f8afc90aca3a534fe51ae7620a Mon Sep 17 00:00:00 2001 From: Christian Pillsbury Date: Thu, 4 Apr 2024 14:41:23 -0700 Subject: [PATCH] chore: update all type imports to explicitly use the type keyword. (#6332) --- src/controller/base-playlist-controller.ts | 9 +++++++-- src/controller/cmcd-controller.ts | 2 +- src/controller/level-controller.ts | 2 +- src/demux/audio/base-audio-demuxer.ts | 16 ++++++++-------- src/demux/audio/mpegaudio.ts | 2 +- src/demux/mp4demuxer.ts | 14 +++++++------- src/demux/video/hevc-video-parser.ts | 5 ++++- src/events.ts | 2 +- src/exports-named.ts | 2 +- src/loader/fragment-loader.ts | 2 +- src/loader/key-loader.ts | 2 +- src/remux/mp4-remuxer.ts | 2 +- src/types/component-api.ts | 2 +- src/types/remuxer.ts | 2 +- src/utils/fetch-loader.ts | 2 +- 15 files changed, 37 insertions(+), 29 deletions(-) diff --git a/src/controller/base-playlist-controller.ts b/src/controller/base-playlist-controller.ts index a3af6988101..c01c8d8d1fb 100644 --- a/src/controller/base-playlist-controller.ts +++ b/src/controller/base-playlist-controller.ts @@ -1,8 +1,13 @@ import type Hls from '../hls'; import type { NetworkComponentAPI } from '../types/component-api'; -import { getSkipValue, HlsSkip, HlsUrlParameters, Level } from '../types/level'; +import { + getSkipValue, + HlsSkip, + HlsUrlParameters, + type Level, +} from '../types/level'; import { computeReloadInterval, mergeDetails } from '../utils/level-helper'; -import { ErrorData } from '../types/events'; +import type { ErrorData } from '../types/events'; import { getRetryDelay, isTimeoutError } from '../utils/error-helper'; import { NetworkErrorAction } from './error-controller'; import { Logger } from '../utils/logger'; diff --git a/src/controller/cmcd-controller.ts b/src/controller/cmcd-controller.ts index 5d472092dd2..5b342a4477c 100644 --- a/src/controller/cmcd-controller.ts +++ b/src/controller/cmcd-controller.ts @@ -1,5 +1,5 @@ import { Events } from '../events'; -import Hls from '../hls'; +import type Hls from '../hls'; import { Cmcd } from '@svta/common-media-library/cmcd/Cmcd'; import { CmcdObjectType } from '@svta/common-media-library/cmcd/CmcdObjectType'; import { CmcdStreamingFormat } from '@svta/common-media-library/cmcd/CmcdStreamingFormat'; diff --git a/src/controller/level-controller.ts b/src/controller/level-controller.ts index 05abe274fc8..a88351749d0 100644 --- a/src/controller/level-controller.ts +++ b/src/controller/level-controller.ts @@ -1,4 +1,4 @@ -import { +import type { ManifestLoadedData, ManifestParsedData, LevelLoadedData, diff --git a/src/demux/audio/base-audio-demuxer.ts b/src/demux/audio/base-audio-demuxer.ts index 01763a141ac..72395d9049d 100644 --- a/src/demux/audio/base-audio-demuxer.ts +++ b/src/demux/audio/base-audio-demuxer.ts @@ -1,12 +1,12 @@ import { - DemuxerResult, - Demuxer, - DemuxedAudioTrack, - AudioFrame, - DemuxedMetadataTrack, - DemuxedVideoTrackBase, - DemuxedUserdataTrack, - KeyData, + type DemuxerResult, + type Demuxer, + type DemuxedAudioTrack, + type AudioFrame, + type DemuxedMetadataTrack, + type DemuxedVideoTrackBase, + type DemuxedUserdataTrack, + type KeyData, MetadataSchema, } from '../../types/demuxer'; import { dummyTrack } from '../dummy-demuxed-track'; diff --git a/src/demux/audio/mpegaudio.ts b/src/demux/audio/mpegaudio.ts index bd90221be32..363f2be7237 100644 --- a/src/demux/audio/mpegaudio.ts +++ b/src/demux/audio/mpegaudio.ts @@ -1,7 +1,7 @@ /** * MPEG parser helper */ -import { DemuxedAudioTrack } from '../../types/demuxer'; +import type { DemuxedAudioTrack } from '../../types/demuxer'; let chromeVersion: number | null = null; diff --git a/src/demux/mp4demuxer.ts b/src/demux/mp4demuxer.ts index 133e15edbbf..6ef4ecfe158 100644 --- a/src/demux/mp4demuxer.ts +++ b/src/demux/mp4demuxer.ts @@ -2,13 +2,13 @@ * MP4 demuxer */ import { - Demuxer, - DemuxerResult, - PassthroughTrack, - DemuxedAudioTrack, - DemuxedUserdataTrack, - DemuxedMetadataTrack, - KeyData, + type Demuxer, + type DemuxerResult, + type PassthroughTrack, + type DemuxedAudioTrack, + type DemuxedUserdataTrack, + type DemuxedMetadataTrack, + type KeyData, MetadataSchema, } from '../types/demuxer'; import { diff --git a/src/demux/video/hevc-video-parser.ts b/src/demux/video/hevc-video-parser.ts index 05cd7d76e1e..f4874cd3041 100644 --- a/src/demux/video/hevc-video-parser.ts +++ b/src/demux/video/hevc-video-parser.ts @@ -1,5 +1,8 @@ import BaseVideoParser from './base-video-parser'; -import { DemuxedVideoTrack, DemuxedUserdataTrack } from '../../types/demuxer'; +import type { + DemuxedVideoTrack, + DemuxedUserdataTrack, +} from '../../types/demuxer'; import { parseSEIMessageFromNALu } from '../../utils/mp4-tools'; import type { PES } from '../tsdemuxer'; diff --git a/src/events.ts b/src/events.ts index c1ebbe224f4..2de4bdb8205 100644 --- a/src/events.ts +++ b/src/events.ts @@ -1,4 +1,4 @@ -import { +import type { ManifestLoadedData, ManifestLoadingData, MediaAttachedData, diff --git a/src/exports-named.ts b/src/exports-named.ts index 4291467997b..9112971399b 100644 --- a/src/exports-named.ts +++ b/src/exports-named.ts @@ -1,7 +1,7 @@ import Hls from './hls'; import { Events } from './events'; import { ErrorTypes, ErrorDetails } from './errors'; -import { Level } from './types/level'; +import type { Level } from './types/level'; import AbrController from './controller/abr-controller'; import AudioTrackController from './controller/audio-track-controller'; import AudioStreamController from './controller/audio-stream-controller'; diff --git a/src/loader/fragment-loader.ts b/src/loader/fragment-loader.ts index 967a143e452..aaf030889ff 100644 --- a/src/loader/fragment-loader.ts +++ b/src/loader/fragment-loader.ts @@ -1,6 +1,6 @@ import { ErrorTypes, ErrorDetails } from '../errors'; import { Fragment } from './fragment'; -import { +import type { Loader, LoaderConfiguration, FragmentLoaderContext, diff --git a/src/loader/key-loader.ts b/src/loader/key-loader.ts index 4badeed8120..accddddf529 100644 --- a/src/loader/key-loader.ts +++ b/src/loader/key-loader.ts @@ -1,5 +1,5 @@ import { ErrorTypes, ErrorDetails } from '../errors'; -import { +import type { LoaderStats, LoaderResponse, LoaderConfiguration, diff --git a/src/remux/mp4-remuxer.ts b/src/remux/mp4-remuxer.ts index bc71b87b7d7..3fdd1e8db79 100644 --- a/src/remux/mp4-remuxer.ts +++ b/src/remux/mp4-remuxer.ts @@ -4,7 +4,7 @@ import type { HlsEventEmitter } from '../events'; import { Events } from '../events'; import { ErrorTypes, ErrorDetails } from '../errors'; import { logger } from '../utils/logger'; -import { +import type { InitSegmentData, Remuxer, RemuxerResult, diff --git a/src/types/component-api.ts b/src/types/component-api.ts index 950af4c10f4..1487640c6cb 100644 --- a/src/types/component-api.ts +++ b/src/types/component-api.ts @@ -1,4 +1,4 @@ -import EwmaBandWidthEstimator from '../utils/ewma-bandwidth-estimator'; +import type EwmaBandWidthEstimator from '../utils/ewma-bandwidth-estimator'; export interface ComponentAPI { destroy(): void; diff --git a/src/types/remuxer.ts b/src/types/remuxer.ts index 8264e5e8084..eca3a933907 100644 --- a/src/types/remuxer.ts +++ b/src/types/remuxer.ts @@ -1,5 +1,5 @@ import type { TrackSet } from './track'; -import { +import type { DemuxedAudioTrack, DemuxedMetadataTrack, DemuxedUserdataTrack, diff --git a/src/utils/fetch-loader.ts b/src/utils/fetch-loader.ts index 0ff08d17c8a..09a74193ed6 100644 --- a/src/utils/fetch-loader.ts +++ b/src/utils/fetch-loader.ts @@ -1,4 +1,4 @@ -import { +import type { LoaderCallbacks, LoaderContext, Loader,