Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Filters are not filtering for Asset Accounts #322

Closed
marcelweikum opened this issue Jul 18, 2024 · 2 comments · Fixed by #337
Closed

Bug: Filters are not filtering for Asset Accounts #322

marcelweikum opened this issue Jul 18, 2024 · 2 comments · Fixed by #337
Assignees
Labels
bug Something isn't working
Milestone

Comments

@marcelweikum
Copy link
Contributor

marcelweikum commented Jul 18, 2024

Describe the bug
The Asset Account Filters you can add in any of the Screens don't work. All Accounts are still displayed.

To Reproduce
Steps to reproduce the behavior:

  1. Create multiple Asset Accounts
  2. Filter for specific Accounts
  3. Still see all Accounts displayed

Expected behavior
When I Filter for Asset Accounts, there should only be the ones displayed, which I selected. On the HomeScreen, Graph and Transactions

Screenshots

image

image

image

Smartphone (please complete the following information):

  • Device: iPhone 14 Pro Max
  • OS: iOS 18.3
  • Version 0.18.0
@marcelweikum marcelweikum added the bug Something isn't working label Jul 18, 2024
@victorbalssa
Copy link
Owner

I definitely need to remove these filters from home screen, it's only for the chart screen I will add it to my ToDo.

@victorbalssa victorbalssa added this to the 0.20.0 milestone Jul 20, 2024
@marcelweikum
Copy link
Contributor Author

marcelweikum commented Jul 23, 2024

I definitely need to remove these filters from home screen, it's only for the chart screen I will add it to my ToDo.

I've tested this a bit:

If you have multiple accounts with different currencies, the filters work just fine on the HomeScreen as well as on transactions, regarding the "Currency" filter. However, if the filters are removed, I don't think there would be a way to check different currency accounts. Handling multiple currencies is also something that the original Firefly-III doesn't manage well in summary...

So maybe remove filters but add an option for switching to different currency accounts.

@victorbalssa victorbalssa modified the milestones: 0.20.0, 0.21.0 Aug 6, 2024
@victorbalssa victorbalssa modified the milestones: 0.21.0, 0.20.1 Oct 5, 2024
@victorbalssa victorbalssa linked a pull request Oct 5, 2024 that will close this issue
@victorbalssa victorbalssa moved this to Done in Abacus Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants