Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not works for canada , +1 #8

Closed
tianyingchun opened this issue Aug 4, 2022 · 9 comments
Closed

Could not works for canada , +1 #8

tianyingchun opened this issue Aug 4, 2022 · 9 comments
Assignees
Labels
question Further information is requested

Comments

@tianyingchun
Copy link

tianyingchun commented Aug 4, 2022

https://codesandbox.io/s/mui-tel-input-p7b2jz?file=/src/App.js

  1. choose canada/us +1

image

image

  1. typings any number like (225) 588-8634

image

it seems that +1 has some bugs here ?

BTW please allow us filter while choose dropdown countries (MUI select control like)

@viclafouch
Copy link
Owner

Hello @tianyingchun

I followed your steps and I have the good result :

image

@viclafouch viclafouch self-assigned this Aug 6, 2022
@viclafouch viclafouch added the question Further information is requested label Aug 6, 2022
@tianyingchun
Copy link
Author

OH basically it seems give us input mistake feelling. please see

if we want to input phone number 407 590 8240 +1

  1. we choose country unitedState it show.

image

that's fine 2. but while we input `407......` it will show us

image

i think +1 country image should not changing while we typing input number, most people will feel there are some wrong ?

@tianyingchun
Copy link
Author

tianyingchun commented Aug 7, 2022

BTW it should support area code is better like +1 (704) 977-1657. ===>(704)

@viclafouch
Copy link
Owner

i think +1 country image should not changing while we typing input number, most people will feel there are some wrong ?

You're right, let me fix that ASAP :)

BTW it should support area code is better like +1 (704) 977-1657. ===>(704)

The value argument of onChange(value) function will be the parsed phone number in E.164 format. For example, if a user chooses "United States" and enters (213) 373-4253 in the input field then onChange(value) will be called with value being "+12133734253".

@tianyingchun
Copy link
Author

good news, when it will be release? waiting :)

@viclafouch
Copy link
Owner

I cannot give you a date sorry ^^

If you want to have the fix very very fast, you can submit a PR ! I'll take a look at it when I get back from vacation.

@tianyingchun
Copy link
Author

:) waiting you fix & relase 👍

@abhishekpolampally
Copy link

Hey this is happening for Aus code as well. +91. Can you please give a solution for this?

Screenshot 2022-09-21 at 1 50 07 PM

Screenshot 2022-09-21 at 1 50 15 PM

@viclafouch
Copy link
Owner

Hey ! I could not reproduce with the last version. Please open a new issue with a sandbox example. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants