Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React 19 as peer-dependency #167

Open
ruiaraujo012 opened this issue Dec 13, 2024 · 4 comments
Open

Add React 19 as peer-dependency #167

ruiaraujo012 opened this issue Dec 13, 2024 · 4 comments

Comments

@ruiaraujo012
Copy link

Now that react 19 is stable, you should add it as a peer dep.

└─┬ mui-tel-input 7.0.0
  ├── ✕ unmet peer @types/react@^18.0.0: found 19.0.1
  ├── ✕ unmet peer react@^18.0.0: found 19.0.0
  └── ✕ unmet peer react-dom@^18.0.0: found 19.0.0

Thanks.

@viclafouch
Copy link
Owner

I don't recommend to update your MUI project to React 19 before mui/material-ui#42381 is completed.

I will wait until is done and then, I will add the compatibility.

@voi99
Copy link

voi99 commented Dec 20, 2024

Hi @viclafouch, MUI now supports React 19. When can we expect a new release?

@Didi3333
Copy link

Didi3333 commented Jan 8, 2025

Hi @viclafouch, when can you update the lib for React 19 please ?

@viclafouch
Copy link
Owner

Hello here !

First, happy new year everyone ! 🤩

Just to let you know, that one library is missing on my side to upgrade to React 19 : Storybook.

Storybook and mainly types are incompatible with React 19. The storybook team are working on it :

I know it's just Storybook, but it can be difficult for me if I need to work on my storybook and having issues with types.

I've subscribed to the storybook PRs. I think it's just a question of days..

When it will be fixed, I will immedialty upgrade React 19 here for mui-tel-input.

For now, you can --force without any problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants