Add automatic ping on websockets #947
Conversation
lultimouomo
force-pushed
the
pingPong
branch
2 times, most recently
from
a06f96d to
562954b
Compare
|
Apparently older versions of std.conv.to do not support dynamic-to-static array conversion; I've now made the conversion manually to support older toolchains. |
| @property const(HTTPServerSettings) serverSettings() const | ||
| { | ||
| return m_settings; | ||
| } |
There was a problem hiding this comment.
I'd leave this as package for now to avoid any potential necessity for API breakage later. If it turns out that this is useful for external libraries/applications, we can still make it public.
Signed-off-by: Luca Niccoli <[email protected]>
It will be made accessible to the websocket via HTTPServerRequest Signed-off-by: Luca Niccoli <[email protected]>
|
Looks good to merge, except for the public |
Makes a const reference to HTTPServerSettings accessible to HTTP delegates. Signed-off-by: Luca Niccoli <[email protected]>
Signed-off-by: Luca Niccoli <[email protected]>
|
I made the settings accessor |
|
Great, thanks! I'll merge as soon as the Travis build is ready. |
Add automatic ping on websockets
The ping interval is fixed at 60 seconds.
The best thing would probably be to set it in the server settings, thus also allowing to disable it entirely.
For this, the
WebSocketmust have access toHTTPServerSettings; the best way would probably be to expose a const reference toHTTPServerRequest.m_settings, which I'm going to do in the next commit of this pull request.