Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping of interpolated attribute values #779

Merged
merged 1 commit into from
Aug 12, 2014

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Aug 12, 2014

Attribute values with interpolated strings are not totally escaped.

a(href="/?t=1&u=1&v=1") foo
- auto params = "t=1&u=1";
a(href="/?#{params}&v=1") foo
<a href="/?t=1&amp;u=1&amp;v=1">foo</a>
<a href="/?t=1&amp;u=1&v=1">foo</a>

@s-ludwig
Copy link
Member

Thanks! Interestingly, the !{...} style interpolations also actually don't really make sense in this context. I'll add an error message for the case of !escape && attribute.

s-ludwig added a commit that referenced this pull request Aug 12, 2014
Fix escaping of interpolated attribute values
@s-ludwig s-ludwig merged commit 11f5980 into vibe-d:master Aug 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants