-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PFS support #630
PFS support #630
Conversation
MartinNowak
commented
Apr 21, 2014
- make DH and ECDH configurable
- choose defaults
- select option to NOT reuse secrets
- make DH and ECDH configurable - choose defaults - select option to NOT reuse secrets
Very nice, I'm going to test that in action right now! Not sure what the Travis error is caused by. /but bah... that OpenSSL API is really one of the worst that I've ever seen. So much that you have to know and do by hand up front to get a secure system. Not even getting started with macro hell and that other stuff... |
Implement PFS support for SSLStream.
Okay, was just an old version of the OpenSSL bindings still being picked up. |
And after some quirks unrelated to this PR have been resolved (ccf7fe1, 9a6fd1a), I'm now getting TLS 1.2 with PFS enabled and pretty good scores on https://www.ssllabs.com/ssltest/. Great! The only issues listed there are now:
But PFS is chosen for any browser that supports it:
|
We might even choose to only support |
True, but I still have my mid term memory filled from updating the headers in case you have any questions. |
Yeah, of all the clients tested on the ssllabs site, no client has chosen a non-ephemeral DH cipher (some older clients had to fall back to non-DH ones), so I guess it should be safe to drop them. |
Actually, I've overlooked some:
So it's probably better to just keep the non-ephemeral ones as intermediate fallbacks. But I guess the (E)DH+3DES modes could be removed. Only old clients will use 3DES and those don't support DH at all (most notably IE on Windows XP). |
It probably doesn't matter, as we use the server preferred order. Not sure if exchanging the available ciphers has some sort of overhead though. |