WebSocket should default to strict receive #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the reason to keep the default non-strict was that browsers didn't even properly implement the binary message type at the time WebSocket support was implemented and also the standard still wasn't finished. It would be interesting to see how the latest versions of each browser vendor behave today. But considering that the RFC is now finished and most browsers should behave correctly, I agree that it makes more sense to have a strict default. |
s-ludwig
added a commit
that referenced
this pull request
Feb 24, 2014
WebSocket should default to strict receive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two methods
receiveTextandreceiveBinaryboth support astrictflag, to enforce the correct frame opcode.It's very counterintuitive that the
strictflag defaults tofalse.http://vibed.org/api/vibe.http.websockets/WebSocket.receiveText