The tests where not working. #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- args/test.sh was out of sync (wrong name provided); - mongodb and restclient used LogLevel.Debug instead of debug_.
|
Yes, those tests haven't been run in a long time and should probably added to Travis (and definitely to our internal CI server) - I'll open a ticket to remember doing that. Thanks for fixing them up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the building failure on the tests.
I also added "exitEventLoop(true);" at the end of the tests.
I wonder however what is the purpose of that folder as they were obviously not run.
Shouldn't they be either moved to "examples", or added to travis ?