Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startup scripts #52

Merged
merged 3 commits into from
May 29, 2012
Merged

Conversation

MartinNowak
Copy link
Contributor

  • use pkg-config if available
  • quote variable expansions to allow spaces in paths

@s-ludwig
Copy link
Member

Thanks for these robustness improvements! Does the pkg-config fix compilation on a particular platform? I would like to include that in the changelog message if possible.

Unfortunately, Mac is causing some problems. "readlink -f" doesn't work on Mac and also pkg-config does not find libevent on if it has been installed using brew. Maybe it makes sense to change the condition from "does the command pkg-config work?" to "does pkg-config -libs ... succeed?" and use the hard coded linker flags otherwise...

@MartinNowak
Copy link
Contributor Author

Does the pkg-config fix compilation on a particular platform?

FreeBSD supports parallel installation of libevent and libevent2 (/usr/local/lib/event2).

readlink -f

It's gone, but I still removed the which.

does pkg-config -libs ... succeed

Turns out to be briefer too.

s-ludwig added a commit that referenced this pull request May 29, 2012
@s-ludwig s-ludwig merged commit 2f8205a into vibe-d:master May 29, 2012
@s-ludwig
Copy link
Member

I just had to add libssl as an explicit dependency but now it works everywhere.. and I could have sworn that the "which" was needed, but obviously it's not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants