Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test and fix markdown parseLink #343

Merged
merged 4 commits into from
Oct 16, 2013
Merged

Conversation

MartinNowak
Copy link
Contributor

No description provided.

@s-ludwig
Copy link
Member

Thanks. Looks good to merge.

s-ludwig added a commit that referenced this pull request Oct 16, 2013
test and fix markdown parseLink
@s-ludwig s-ludwig merged commit aa3c081 into vibe-d:master Oct 16, 2013
@MartinNowak
Copy link
Contributor Author

My actual problem was that I switched from sundown which allowed spaces in URLs.
But as this isn't broadly supported I left it as it was.
There is also no test case for this in https://github.com/jgm/peg-markdown/tree/master/MarkdownTest_1.0.3.
Would be interesting to use the test suite though.

@MartinNowak MartinNowak deleted the parseLink branch October 16, 2013 07:13
@s-ludwig
Copy link
Member

My guess is that this test suite will get particularly interesting when whitespace gets involved. Getting together a half clean markdown parser that is not based on a cascade of regexes was an interesting challenge, but so far I haven't looked at all at how line breaks and other whitespace is output (at least only so far that the rendered HTML is correct). But I agree that this should be the goal. In fact this module screams for unittests (but was still done in a time when getting things done fast had priority over writing unit tests for already working things).

I'd also really like to support Michel Fortin's extras and SmartyPants on top at some point. But before that is tackled, a proper test suite is mandatory, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants