-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split / move restutil
module
#340
Conversation
Move those smaller modules into freshly created `vibe.utils.meta` package. vibe.d code style was enforced in process, documented unittest feature used, few small bugs fixed.
Worth noting though that I current vibe.d master is hopelessly broken on 2.063.2 and with dmd master I can't run rest unittests because of I am afraid that abandoning normal "last 2 versions" approach is needed for now and returning to it once CI stuff is running - there is no way we can patch all the ICE's with workarounds. |
Please report any ICE to Bugzilla, mark the bug as regression, choose proper keywords, if necessary raise the priority and most import try to provide a reduced test case (DustMite). |
@dawgfoto most are fixed in current DMD master, no problem here! Problem is that in absence of CI vibe.d master was rarely tested on 2.063.2 and right now triggers several bugs on last released version. Usually @s-ludwig tries to support 2 last releases of DMD simultaneously providing temporary workarounds for such stuff - I am afraid there is no way to conform to this approach easily in current state. So it is not yet another DMD rant ;) |
If it's just that unittest issue, lets just put a |
Anyway, it looks much better/cleaner now. I'll merge and see if a few things from |
Split / move `restutil` module
No, you have misunderstood, unittests fail with current master (2.064). On 2.063.2 it simply results in DMD ICE. |
Hm OK and the ICE is one that is not solved by the |
But regarding the failed unit test.. I don't get it. I've frequently built with "-unittest" in the past days and nothing ever failed. But for some reason, from time to time, certain tests still fail in other environments (sometimes rightfully so and sometimes they shouldn't). But this looks like it may be triggered by some bug along the lines of http://d.puremagic.com/issues/show_bug.cgi?id=11225? |
@s-ludwig No idea, I did not want to distract upon reducing the root case for that ICE and just switched compiler version to master to move forward. Regarding failing unittest:
DMD built from commit |
This is some kind of "preparation" request before implementing decorator feature we have recently discussed.
As this will involve adding quite a lot of metaprogramming facilities I have started with cleaning existing stuff
in
vibe.http.restutil
and moving it to appropriate generic place.In process have noticed and fixed some bugs and adjusted everything to published code style.