added support for enums (or other string convertable types) as keys to m...

[patefacio]

...aps for json serialization

[s-ludwig]

Thanks, this is a good idea. The only thing that needs to be rebalanced now a bit is serialization vs. deserialization. The idea is that anything that can be serialized must also be deserializable, so a check is needed in serializeJson to see if the key type can also be used as to!Key(string) and only then allow it. Also, handling types that define both toString and fromString (i.e. isStringSerializable!Key) would be nice (I think to!Key(string) doesn't look for a fromString static method).

Should you be willing to extend it prior to pulling, that would be great! Otherwise I can pull it and do the rest of the changes myself (probably early next week).

[patefacio]

Great, thanks. Good ideas - I'll certainly give it a go and see if I can extend as you suggest.

---

From: Sönke Ludwig [email protected]
To: rejectedsoftware/vibe.d [email protected]
Cc: Daniel Davidson [email protected]
Sent: Thursday, October 3, 2013 1:20 AM
Subject: Re: [vibe.d] added support for enums (or other string convertable types) as keys to m... (#333)

Thanks, this is a good idea. The only thing that needs to be rebalanced now a bit is serialization vs. deserialization. The idea is that anything that can be serialized must also be deserializable, so a check is needed in serializeJson to see if the key type can also be used as to!Key(string) and only then allow it. Also, handling types that define both toString and fromString (i.e. isStringSerializable!Key) would be nice (I think to!Key(string) doesn't look for a fromString static method).
Should you be willing to extend it prior to pulling, that would be great! Otherwise I can pull it and do the rest of the changes myself (probably early next week).
—
Reply to this email directly or view it on GitHub.

[mihails-strasuns]

Something is very wrong with whitespaces in this block.

[patefacio]

Yes, I don't quite understand it... I think it looks ok in the source:
https://github.com/patefacio/vibe.d/blob/master/source/vibe/data/json.d

}elsestaticif(isAssociativeArray!T){ aliastypeof(T.init.values[0])TV; aliasKeyType!TTK; Unqual!TV[TK]dst; foreach(stringkey,value;src){ staticif(is(TK==string)){ dst[key]=deserializeJson!(Unqual!TV)(value); }elsestaticif(is(TK==enum)){ dst[to!(TK)(key)] = deserializeJson!(Unqual!TV)(value); }elsestaticif(isStringSerializable!TK){ autodsk=TK.fromString(key); dst[dsk]=deserializeJson!(Unqual!TV)(value); } } returndst;

---

From: Михаил Страшун [email protected]
To: rejectedsoftware/vibe.d [email protected]
Cc: Daniel Davidson [email protected]
Sent: Thursday, October 3, 2013 9:31 AM
Subject: Re: [vibe.d] added support for enums (or other string convertable types) as keys to m... (#333)

In source/vibe/data/json.d:

@@ -899,8 +899,16 @@ Json serializeToJson(T)(T value)
return Json(ret);
} else static if( isAssociativeArray!TU ){
Json[string] ret;

• foreach( string key, value; value )
  

•     ret[key] = serializeToJson(value);
  

•         alias KeyType!T TK;
  

• foreach( key, value; value ) {
  

•                     static if(is(TK == string)) {
  

•                            ret[key] = serializeToJson(value);
  

•                     } else static if(is(TK == enum)) {
  

•                            ret[to!string(key)] = serializeToJson(value);
  

•                     } else static if(isStringSerializable!(TK)) {
  

•                            ret[key.toString()] = serializeToJson(value);
  

•                     }
  

•            } 
  

  Something is very wrong with whitespaces in this block.
  —
  Reply to this email directly or view it on GitHub.

[simendsjo]

You've used spaces rather than tabs. Don't you use an editor that visualize tabs? :)

[patefacio]

What makes you say that? Do you see spaces in the source?

[simendsjo]

Hmm. Selecting text in github shows there are spaces in this code, while tabs everywhere else.

[mihails-strasuns]

Checked source file as-is and it has tabs with extra trailing single space. Maybe that is what confuses github.

[s-ludwig]

Looks good as far as I can see. I'll double check the whitespace after merging. The display on GitHub is often strange and I generally completely ignore that and look at the actual code instead. It's a nice opportunity for improvement, though. Is there a public issue tracker for github itself somewhere?

[mihails-strasuns]

Is there a public issue tracker for github itself somewhere?

Not I am aware of.

[patefacio]

No worries on this though, it was my fault. There were indent issues (I was looking at the wrong place).
Sorry about that - I use emacs but my D mode is quite different so I was going back and forth between D mode and text mode
and doing a slew of tabify calls.

Thanks
Dan

---

From: Михаил Страшун [email protected]
To: rejectedsoftware/vibe.d [email protected]
Cc: Daniel Davidson [email protected]
Sent: Thursday, October 3, 2013 3:32 PM
Subject: Re: [vibe.d] added support for enums (or other string convertable types) as keys to m... (#333)

Is there a public issue tracker for github itself somewhere?
Not I am aware of.
—
Reply to this email directly or view it on GitHub.