HTTPServer - add support for HTTP informational status message sending #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds possibility to send HTTP status messages (1xx) using
writeVoidBodyinHTTPServerResponse.I've modified also the client that now can receive these messages in it's
responderhandler prior the final response.What's not handled properly is
100 Continueas client just sends the body right away.I'm not so sure how to fix that as
requestershould begin to write body after100 Continueis received from the server inresponder. Maybe using semaphore betweenrequesterandresponder?But this can probably be handled separately as this PR doesn't change the current behavior for that.