Made WebParamAttribute public to allow rest introspection #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ludwig
reviewed
Jan 11, 2019
web/vibe/web/common.d
Outdated
| ParameterKind origin; | ||
| /// Parameter name | ||
| /// Parameter name (Server side) |
There was a problem hiding this comment.
What about "function parameter name" to make this even more clear?
s-ludwig
approved these changes
Jan 11, 2019
I'm currently building a angular service generator. This is done by introspecting rest interfaces. To get the parameter names right, it needs to look at the UDAs, and more specifically at WebParamAttribute. * Sönke remarks worked in
burner
force-pushed
the
WebParamAttribute_public
branch
from
026b970 to
904a8c6
Compare
|
@s-ludwig thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently building a angular service generator.
This is done by introspecting rest interfaces.
To get the parameter names right, it needs to look at the UDAs, and more
specifically at WebParamAttribute.