Fix Json array clone #2249
Merged
Fix Json array clone #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gedaiu
force-pushed
the
fix-array-clone
branch
from
fb9ba02 to
01cc20c
Compare
|
I guess the |
s-ludwig
approved these changes
Jan 10, 2019
There was a problem hiding this comment.
There is appendArrayElement, which sounds like it should be the same as addObject. This issue is one of the things that lead to stdx-data-json not having any of these convenience operators directly in its value type. Although it definitely reduces the amount of visual noise in some places, the effects can often be unexpected in a statically typed language.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2246