Fix OpenSSL 1.1.1 by using new APIs #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changes minimum protocol version to new API Split the error handling API to be more usable Fix IO error message fix vibe-d#2214
|
Couldn't test OpenSSL 1.0.0 locally because of linking errors which existed before the PR already (no, the libs hack doesn't fix it because then it segfaults trying to mix 1.1.1 and 1.0.0) |
s-ludwig
reviewed
Nov 6, 2018
tls/vibe/stream/openssl.d
Outdated
| b.flags = 0; | ||
| b.ptr = null; | ||
| BIO_set_init(b, 0); | ||
| BIO_clear_flags(b, int.max); |
There was a problem hiding this comment.
Don't you mean -1 (or better ~0) here?
|
Looks fine to me. Since the CI tests pass, the 1.0.x branch should still be fine. I'd test for 1.1.0 after the merge and before tagging a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new BIO methods
more error handling
Also changes minimum protocol version to new API
Split the error handling API to be more usable
Fix IO error message
fix #2214