fix returning hostname from uname on posix #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetarKirov
approved these changes
Oct 17, 2018
core/vibe/core/log.d
Outdated
| utsname name; | ||
| if (uname(&name)) return hostName; | ||
| hostName = name.nodename.to!string(); | ||
| hostName = (&name.nodename[0]).fromStringz().idup; |
There was a problem hiding this comment.
Simply name.nodename.ptr.to!string should do the trick.
|
tchaloupka
force-pushed
the
fix_hostname
branch
from
e885a31 to
1472fee
Compare
|
Great, didn't know that, better? :) |
perfect ;) |
|
Thanks for the fix, I'll check vibe-core now. The documentation is quite confusing, considering that |
s-ludwig
added a commit
to vibe-d/vibe-core
that referenced
this pull request
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in documentation
nodenameischar[]of unspecified size and string is null terminated.There is specified size of 65 in druntime.
But
to!stringon the char array doesn't handle null terminated string but just returns it in a full length with nulls.I've found this out on one of the servers where something strange was logged and it was exactly 65 chars in length.
Fixed it using
std.string.fromStringz.Note: This should be fixed in vibe-core too