Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RestInterfaceSettings.dup() for errorHandler callback #2197

Merged
merged 2 commits into from
Aug 14, 2018
Merged

Fix RestInterfaceSettings.dup() for errorHandler callback #2197

merged 2 commits into from
Aug 14, 2018

Conversation

vitalka200
Copy link
Contributor

Added missing fields copy in RestInterfaceSettings.dup().

Without this, setting errorHandler callback will not work because
of this in module vibe.web.internal.rest.common:L118

this.settings = settings ? settings.dup : new RestInterfaceSettings;

@vitalka200
Added HTTPClientSettings.dup()
94f7a5e
@vitalka200
Added missing fields copy for RestInterfaceSettings
030bcdd 
- Added copy for .errorHandler
- Added copy for .httpClientSettings
@vitalka200
Copy link
Contributor Author

@s-ludwig @wilzbach When it can be merged?

@wilzbach wilzbach merged commit c350d39 into vibe-d:master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilzbach wilzbach wilzbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitalka200 @wilzbach