Auto-detect OpenSSL 1.1

[wilzbach]

This is ugly, because dub is quite limited in this regard.
However, the preBuildsCommands + rdmd has been successfully used for a couple of
repositories at dlang-community already.

Also, I don't think this will work on Windows, but if the detection fails, the current behavior (i.e. using OpenSSL 1.0) is maintained.
For Posix-systems this should help a people a lot though and allows a good first five minutes experience.

edit: enabled it only for Posix systems

[jacob-carlborg]

Will RDMD automatically pick LDC/GDC if DMD is not available?

[wilzbach]

Yes. In fact it will even prefer ldc if ldc is in the same directory.

[Geod24]

If this script fails, will it fail the build ?

[wilzbach]

Yes, but that's why the idea is to softly fail to 0.0.0 if no version could be detected. I also added a try/catch to be sure and enabled it for Posix only.

[wilzbach]

rdmd --eval doesn't work with 2.075: https://travis-ci.org/vibe-d/vibe.d/jobs/405854762

[WebFreak001]

the new mixin configs based on command output thingy that's being (been?) merged into dub could be useful here right?

[jacob-carlborg]

the new mixin configs based on command output thingy that's being (been?) merged into dub could be useful here right?

Do you have any link for that?

[WebFreak001]

@jacob-carlborg dlang/dub#1453

[wilzbach]

the new mixin configs based on command output thingy that's being (been?) merged into dub could be useful here right?

Yep, but it's uncertain whether this will be approved (and it will take quite a while until this dub version is available/used everywhere). In the meantime, this trick works and removes the TLS configuration pain for Posix.

[wilzbach]

@s-ludwig: what's your opinion on this? Or can we finally move ahead with this?
It's been quite a while...

[s-ludwig]

We should definitely move forward, I wanted to do that for months now actually...

I mainly have two points:

• Splitting up the "openssl" configuration is a potentially breaking change, what was the reason for that instead of sticking platform="..." on each declaration as required?
• I'd probably go ahead one step further and make 1.1 the default if detection fails (adding an "openssl-1.0" configuration to force 1.0)

[wilzbach]

Splitting up the "openssl" configuration is a potentially breaking change, what was the reason for that instead of sticking platform="..." on each declaration as required?

This:

Warning: Multiple configurations with the name "openssl" are defined in package "vibe-d:tls". This will most likely cause configuration resolution issues.

I'd probably go ahead one step further and make 1.1 the default if detection fails (adding an "openssl-1.0" configuration to force 1.0)

Awesome! Done.

[s-ludwig]

What I mean is this:

configuration "openssl" {
	dependency "openssl" version="~>1.0"

	// Windows
	sourceFiles "../lib/win-i386/eay.lib" "../lib/win-i386/ssl.lib" platform="windows-x86-dmd"

	// Posix
	sourceFiles "openssl_version.d" platform="posix"
	preBuildCommands `rdmd --eval='
	auto dir = environment.get("DUB_PACKAGE_DIR");
	if (dir.buildPath("tls").exists)  {
		dir = dir.buildPath("tls");
	}
	auto opensslVersion = "0.0.0";
	try {
		const res = execute(["openssl", "version"]).output;
		if (res.canFind("OpenSSL ")) {
			opensslVersion = res.splitter(" ").dropOne.front.filter!(not!(std.uni.isAlpha)).text;
		}
	} catch (Exception e) { writeln("Warning: ", e); }
	text("module openssl_version;\nenum OPENSSL_VERSION=\"", opensslVersion, "\";").
		toFile(dir.buildPath("openssl_version.d"));
	'` platform="posix"
}

I think this should work fine.

Looks like you accidentally added some .orig files in the last commit.

[wilzbach]

I think this should work fine.

Ah I see. Thanks! Updated.

Looks like you accidentally added some .orig files in the last commit.

Yeah I was in a bit of a hurry. Sorry. Fixed.

[s-ludwig]

Upgraded and fixed the Windows side to work with OpenSSL 1.1, too. Let's hope it passes now.

[wilzbach]

Awesome. Thanks a lot! I guess we can release 0.8.5 fairly soon then?

[s-ludwig]

Definitiely! I'd just try wait for #2247 before tagging the beta (but speaking of which, I'll just tag a new alpha right now).

[bubnenkoff]

Can't build latest vibed on Windows 10 with follow error
#2261