-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mongodb 3.6 aggregate #2037
Conversation
Exception constructors should use size_t for lines in order to work with std.exception.enforce
fix vibe-d#2036, fix vibe-d#1718 cursors now only need the DocType as template argument, the find specific arguments are now in the constructor. Aggregate now uses Cursors and find was altered to the new API. There is a deprecated compatibility alias which will work in most cases (except if only Q was given and differs from what R should be, which shouldn't even be done anyway) The new public API for aggregate is a lot more like the shell now, but still supports the old way
also ran into #2036 but after patching this in vibe I get:
|
@timotheecour try upgrading the dub dependency. I merged master into this now but now I get a completely unrelated error which complains about |
ya i got this as well, depending on how i do things: ../../../D/vibe.d/stream/vibe/stream/memory.d(56,42): Error: constructor vibe.utils.array.AllocAppender!(ubyte[], ubyte).AllocAppender.this (IAllocator alloc, ubyte[] initial_buffer = null) is not callable using argument types (IAllocator) |
That indicates that your |
huh on the test servers it paseses so I guess it's not broken ¯\_(ツ)_/¯ |
I'll have to see whether we can improve the transition from |
This PR replaces the aggregate function and adds support for options and makes MongoCursor more extensible with support for any cursors instead of only
find
cursorsfix #2036, fix #1718
Tested with latest MongoDB 3.2, 3.4, 3.6