Fix compilation on DragonFlyBSD #2028
Conversation
dkgroot
commented
Jan 10, 2018
dkgroot
commented
- Also do a little formatting cleanup
- Add static assert to prevent compilation when IP_ADD_MEMBERSHIP, IP_MULTICAST_LOOP are missing (not sure if this is preferred or not)
….netinet.in_' is fine, when compiler support is there.
core/vibe/core/drivers/libevent2.d
Outdated
| @@ -77,6 +77,13 @@ version(Windows) { | |||
| } | |||
| else | |||
| import core.sys.freebsd.netinet.in_ : IP_ADD_MEMBERSHIP, IP_MULTICAST_LOOP; | |||
| } else version (DragonFlyBSD) { | |||
| static if (__VERSION__ < 2077) { | |||
There was a problem hiding this comment.
Shouldn't this be 2079 ? Since it's not merged yet, and 2078 was already released.
There was a problem hiding this comment.
You raising this question, made me think about this again. As this source is only going to be compiled/used when the changes have already landed in the compiler + druntime. It does make sense to even check the compiler version. I will remove this static if and just import core.sys.dragonflybsd.netinet.in_. There really is not need for the fall back.
core/vibe/core/drivers/libevent2.d
Outdated
| } | ||
| else version (DragonFlyBSD) | ||
| { | ||
| static if (__VERSION__ < 2077) { |
There was a problem hiding this comment.
Somehow the comment of @Geod24 is shown as outdated, but he is right, this should be __VERSION__ < 2079 (or even later, if core.sys.dragonflybsd doesn't get merged into druntime master before 2.079)
There was a problem hiding this comment.
See
No need to check the compiler version. It's like a chicken/egg issue, without compiler support there is not way to get to this code. When compiler support lands, then core.sys.dragonflybsd.netinet.in_ will exist.
|
@thaven I fully agree. It would make more sense and be a lot nicer if there was an generic interface that could be referred to. |
….netinet.in_" will work, when compiler support is there. [See](vibe-d/vibe.d#2028 (comment))
|
Usually those constants actually are in druntime, but unfortunately they are just being added on a per-case basis instead of thoroughly going through each C header. I used to make druntime PR's for such missing constants, but lately I've been getting too busy and had to focus on just getting vibe.d to work. |
|
Ok understood. Thanks for merging this PR ! |
