Make vibe.web.web.redirect similar to HTTPServerResponse.redirect #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaven
suggested changes
Oct 11, 2017
web/vibe/web/web.d
Outdated
| @@ -378,6 +378,12 @@ void redirect(string url) | |||
| ctx.res.redirect(fullurl); | |||
There was a problem hiding this comment.
I suppose status should be passed here....
There was a problem hiding this comment.
And found instead of Found ("deprecated")
web/vibe/web/web.d
Outdated
| /// ditto | ||
| void redirect(URL url, int status = HTTPStatus.Found) | ||
| @safe { | ||
| redirect(url.toString); |
wilzbach
force-pushed
the
redirect-upgrade
branch
from
644e716 to
cde8758
Compare
|
Finally found time to rebase this PR - sorry for the forgetting to pass on |
|
Ping @s-ludwig - this has been ready for five months now ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide the same API as
HTTPServerResponse.redirect