Allow listenHTTP to accept a convenience setting string #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilzbach
commented
Jul 4, 2017
|
|
||
| shared static this() | ||
| { | ||
| listenHTTP(":11721", (scope req, scope res) { |
There was a problem hiding this comment.
I copied the hard-coded port from other tests - how about adding something like getFreePort to Vibe.d?
There was a problem hiding this comment.
Or supporting ":0" and providing a way to retrieve the actual listen port.
s-ludwig
approved these changes
Jul 5, 2017
@s-ludwig are you sure that you configured the webhook correctly here? I can't find any events in the log.
|
|
Yay, finally worked! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1810
Now that
HTTPServerSettingsaccept a string,listenHTTPcan do so as well 🎉Instead of adding five new overloads, I opted for templates.