-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add convenience constructor to HTTPServerSettings. #1810
Conversation
Allows to specify the bind interface and port as a single constructor argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this - LGTM!
A future extension might accept commas to allow multiple addresses, though I highly doubt that this is a common use case and would need to be part of the convenience constructor.
Something still appears to be wrong with CodeCov - it doesn't pick up the unit test that is added by this patch at all: https://codecov.io/gh/rejectedsoftware/vibe.d/compare/3048f34149ecbd1fdd0362cebe0432e65105e008...4517e3769887f8912df66a8527479e43188aa589/src/http/vibe/http/server.d#L642 |
It's most likely a problem on our side - one can download the uploaded report if one clicks on a respective commit and then on the "Build" tab: https://codecov.io/gh/rejectedsoftware/vibe.d/commit/4517e3769887f8912df66a8527479e43188aa589/build I guess a first problem is that we don't merge the coverage files as they seem to be in different folder:
This can be done with However, I don't know why in all of 22 server files, there's none which coverage:
Not sure why the all |
Allows to specify the bind interface and port as a single constructor argument