Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "before" annotations on REST interface classes. #1754

Merged
merged 2 commits into from
May 7, 2017

Conversation

s-ludwig
Copy link
Member

@s-ludwig s-ludwig commented May 4, 2017

Fixes #1753.

@Geod24
Copy link
Contributor

Geod24 commented May 5, 2017

Shouldn't @before on interface be discouraged ? The problem is that it describes server-only behavior so it can easily make the interface unusable for client generation (e.g. if the @before function have dependency on the DB, it drags it into the client as well).

@s-ludwig
Copy link
Member Author

s-ludwig commented May 6, 2017

Definitely should be discouraged in their current form. The problem is that only those on the interface seem to have worked for a while now and I didn't notice when that became the case (don't use them anywhere anymore, AFAIR). So I'd let them go through a full deprecation cycle (doc -> warn -> error) to make sure they only appear on the class (and maybe any base class).

@s-ludwig s-ludwig force-pushed the issue_1753_before_on_class branch from 03b90b9 to e46390c Compare May 6, 2017 14:49
@s-ludwig s-ludwig merged commit d2ec9d1 into master May 7, 2017
@s-ludwig s-ludwig deleted the issue_1753_before_on_class branch May 14, 2017 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants