Respect explicitly set Content-Type in sendFile #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, definitely makes sense! In the current version, you could also use the |
s-ludwig
added a commit
that referenced
this pull request
Dec 19, 2016
Respect explicitly set Content-Type in sendFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using sendFile, the Content-Type header is automatically set based on file extension. While this default behaviour is fine, the problem is that the header is overwritten if already explicitly set.
In my case, files are not stored using any extension, so all files are treated as application/octet-stream. I have the correct media type stored elsewhere, and it would be nice if I could manually specify this, without having the header overwritten internally.