Let serializers get a type traits struct instead of the raw type. #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ludwig
force-pushed
the
traits_based_serializers
branch
from
33cbe80 to
7c00d71
Compare
The traits struct in particular carries UDA information, which allows serializers to support serializer specific UDAs. ***This is a breaking change for any serializer implementations**. The expectation though is that the only existing seriailzer implementations are currently the ones in vibe.d itself.
This enables the deserializer to access field attributes and other useful information.
s-ludwig
force-pushed
the
traits_based_serializers
branch
from
7c00d71 to
abbf07d
Compare
|
Cleaned up the diff and added |
|
The changes look pretty straightforward. I see no issues. (btw good idea to separate T => Traits rename) |
|
Thanks for reviewing! I still often do not manage to focus on doing a single thing at a time, so I had to rework the commit history quite heavily to get it to a reviewable state ;-) BTW, I'll get to #1547 shortly (still in vacation, but maybe tomorrow when we are on the ferry), but it looks like what I had in mind for such an implementation. |
|
Hehe, I thought the best way to get your attention would be to review something :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change for any serializer implementations. The expectation though is that the only existing seriailzer implementations are currently the ones in vibe.d itself.
The traits struct in particular carries UDA information, which allows serializers to support serializer specific UDAs. The code has also been refactored a bit to reduce line length/visual noise.