Implemented array support: issue 14 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be used for flexible form data, when fields might or might not be provided and you actually don't care.
In addition it is fully recursive, so arbitrary nested structures/arrays will be handled correctly. Implementation has already been tested with the old examples, so it is at least not worse than the old one. Arrays have not been tested thoroughly yet.
|
:D That itching in the fingers can sometimes be an ass! I'll check the unit test issue... and I guess now I have to convert something to use this ;) |
s-ludwig
added a commit
that referenced
this pull request
Nov 28, 2012
Implemented array support: issue 14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well there was neither the time nor the need for it, I did it anyway.
Traversal is now fully recursive. So structures containing structures containing arrays containing arrays containing structures ... are supported now.
The array stuff has not been completely tested yet, but it looks good and at least it the old examples still behave in the same way, so it is at least a good replacement for the old implementation.
In addition the loadFormData() method was provided, which can be used to fill a struct with form data if you don't require all fields to be present in the form.
Docs need to be updated. (Coming soon)
Btw. when adding "-unittest" to dflags in package.json, I get linker errors. Any idea what's the matter?