[REST] Allow empty path to be treated as '/' #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Disallowing |
Geod24
force-pushed
the
userman-rest
branch
2 times, most recently
from
8d5e92e to
71be094
Compare
Previously, having a function named with one of the prefixes (e.g: `get`, `post`, `query`) would result in a different behavior in the web and rest interface. The REST interface will generate faulty code that could crash at some point, while the web generator will treat that as a '/'. Instead of special-casing this, this commit makes it an error. This error will be triggered when `registerXXXInterface` is called, thus it is a CT error, but it was not possible to make it a deprecation since we're dealing with CTFE.
|
Updated to transform |
Geod24
changed the title
Merged
s-ludwig
added a commit
that referenced
this pull request
Jun 15, 2015
[REST] Allow empty path to be treated as '/'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first steps taken are to assert on an empty / null path in the router.
I then considered a special handling for empty string as path, which would basically make it work like '/'.
But that would be quite an annoying change, but it could be potentially dangerous on update. So there's now an assert in
vibe.web.common.extractHTTPMethodAndName.In addition, I realized that the web interface was using it, so I made the error message clearer. The change involved is quite trivial.
Note about unrelated changes: I (finally) set up editor config on my emacs. Which means everytime I save a file I edited, it is normalized to be conformant to the settings in
.editorconfig, which is why there is so much noise.