Better REST automatic method implementation generation ( qualified type names + local module import ) #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 7, 2012 03:11
…ding in REST interfaces. Restored from accidently deleted repo :)
|
Very nice. I'll merge and test on my stuff ASAP. |
s-ludwig
added a commit
that referenced
this pull request
Oct 12, 2012
Better REST automatic method implementation generation ( qualified type names + local module import )
|
Apart from some typos (fixed 367c975) everything seems to work nicely. This will make the interface stuff much more robust, thanks again! |
|
Added support for enums and static arrays in 9b52c0b. Phobos fullyQualifiedName! does not seem to work with inner types - it just outputs the unqualified name - so I disabled the corresponding unit tests for now. -> http://d.puremagic.com/issues/show_bug.cgi?id=8806 |
|
Yeas, that is related to dlang/phobos#826 pull request - it has been merged, but I assume you are not using master phobos version :) I ll do an update on next dmd/phobos release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #104
I think it is done now. Utility templates looks a bit more monstrous now, but that is because I have made an according pull requests to phobos :
dlang/phobos#863
dlang/phobos#862
Until it is accepted ( and released ) or rejected an exact copy is included in this pull request