Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecation notice for index handling in vibe.web.rest #1010

Merged
merged 2 commits into from
Mar 25, 2015
Merged

Remove deprecation notice for index handling in vibe.web.rest #1010

merged 2 commits into from
Mar 25, 2015

Conversation

Geod24
Copy link
Contributor

@Geod24 Geod24 commented Mar 12, 2015

This had been deprecated in fe6a5de and so this message is there since July 2013 (and not relevant anymore). Time to remove it ?

@s-ludwig
Copy link
Member

Instead of removing just the deprecation message, the whole index special case should be removed. For that we'd need something like a disable_index_special_case = false parameter for extractHTTPMethodAndName, because unfortunately the vibe.web.web module still needs to support it (although it was never supposed to be supported there in the first place).

@Geod24
Copy link
Contributor Author

Geod24 commented Mar 12, 2015

Since there was no other code, I though it was already removed. I'll take a look later this week then.

@Geod24 Geod24 force-pushed the fix-deprecation-rest branch from 379e138 to c6abfb5 Compare March 25, 2015 22:23
@Geod24
Copy link
Contributor Author

Geod24 commented Mar 25, 2015

Updated (and added small cosmetic changes).

s-ludwig
s-ludwig reviewed Mar 25, 2015
View reviewed changes
source/vibe/web/rest.d
'id' is expected to be part of the URL instead of a JSON request. Parameters with default
values will be optional in the corresponding JSON request.
'id' is expected to be part of the URL instead of a JSON request. Parameters with default
values will be optional in the corresponding JSON request.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be tabs instead of spaces. I'll fix that after merge.

@s-ludwig
Copy link
Member

There still seems to be a missing false template parameter at rest.d line 813 according to Travis.

@Geod24 Geod24 force-pushed the fix-deprecation-rest branch from c6abfb5 to 6199883 Compare March 25, 2015 22:41
@s-ludwig
Copy link
Member

Nevermind. Your fix came in just in the second I commented.

@Geod24
Copy link
Contributor Author

Geod24 commented Mar 25, 2015

Yup, and that means the unittest don't cover that line. Reminds me that I never checked the coverage on Vibe.
It should be fixed now (and tabs are in).

@Geod24
Copy link
Contributor Author

Geod24 commented Mar 25, 2015

Green :)

s-ludwig added a commit that referenced this pull request Mar 25, 2015
@s-ludwig
Merge pull request #1010 from Geod24/fix-deprecation-rest
d0c9db3 
Remove deprecation notice for index handling in vibe.web.rest
@s-ludwig s-ludwig merged commit d0c9db3 into vibe-d:master Mar 25, 2015
@Geod24 Geod24 deleted the fix-deprecation-rest branch April 27, 2015 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Geod24 @s-ludwig