Enable default block content in Diet templates #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Jade templates, you can define a default block content which is used if no content for a block is provided. This is also possible with vibe.d - but an assertion prevents this. IMHO the assertion is a cut'n'paste error. Removing it enables use of default block content.
|
Hm, interesting. In fact this was never implemented (the |
s-ludwig
added a commit
that referenced
this pull request
Mar 9, 2015
Enable default block content in Diet templates
s-ludwig
added a commit
that referenced
this pull request
Mar 9, 2015
The append mode now triggers an error message as before.
|
Okay should be working correctly now. With only the assertion removed it would always append the default block contents, even if the block was overridden. "prepend" also works, but "append" is disabled again, as that is a little more involved to implement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Jade templates, you can define a default block content which is used if no content for a block is provided.
This is also possible with vibe.d - but an assertion prevents this.
IMHO the assertion is a cut'n'paste error. Removing it enables use of default block content.