-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide ability to publish and consume binary data directly #267
Comments
Another bad thing I discovered is that your API is non-consistent in terms of data types. So we publish the String and consume byte[] |
The PR with fix is #268 For master com.viartemev.thewhiterabbit.channel.TxChannel.Transaction line 37 fix needed. |
@laserg thank you for contribution. |
Give me a couple of minutes. I will fix PR. |
@laserg I agree with you about inconsistency. But this problem should be solved in another issue. Before that, all required parameters should be collected and after we can move to one general type. |
@viartemev Yep. Now #268 |
This feature available in version 0.0.6 |
@viartemev, please do not forget to close this issue. |
CASE:
OutboundMessage#msg is a String,
In this way, it forces us to use marshalling (XML, JSON, YML) insted of serialization (CBOR, protobuf)
In the case of converting a binary array to we at least lose time. In addition, the string representation of the binary array will weigh twice as much since char = 16 bit vs byte = 8 bit
For instance you can compare implementtion of methods dump and dumps in kotlinx/serialization/SerialImplicits.kt kotlinx-serialization-runtime-0.11.1
The text was updated successfully, but these errors were encountered: